On Tue, 1 Oct 2024 10:39:08 GMT, Abhishek Kumar <[email protected]> wrote:
>> Jayathirth D V has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update for review comments
>
> test/jdk/java/awt/Window/InvalidFocusLostEventTest/InvalidFocusLostEventTest.java
> line 47:
>
>> 45: private KeyboardFocusManager fm;
>> 46:
>> 47: static boolean failed = false;
>
> should be Volatile ?
With updated code this variable is accessed only in 1 thread. So i am keeping
it as non-volatile.
> test/jdk/java/awt/Window/InvalidFocusLostEventTest/InvalidFocusLostEventTest.java
> line 57:
>
>> 55: if (f != null) {
>> 56: f.dispose();
>> 57: }
>
> should be disposed on EDT.
Updated.
> test/jdk/java/awt/Window/InvalidFocusLostEventTest/InvalidFocusLostEventTest.java
> line 79:
>
>> 77: robot.setAutoDelay(100);
>> 78: robot.setAutoWaitForIdle(true);
>> 79: Point bp = b.getLocationOnScreen();
>
> should be on EDT.
Updated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21281#discussion_r1785758822
PR Review Comment: https://git.openjdk.org/jdk/pull/21281#discussion_r1785758179
PR Review Comment: https://git.openjdk.org/jdk/pull/21281#discussion_r1785757883
