On Sat, 5 Oct 2024 21:13:36 GMT, Alexander Zvegintsev <[email protected]> wrote:
> More tests to open source: > > - java/awt/Frame/FocusTest.java - in the [problem > list](https://bugs.openjdk.org/browse/JDK-8341480) on macos > - java/awt/Frame/InitialIconifiedTest.java - added undecorated case, and > improved failure detection for macos > > Testing looks good. LGTM other than the minor comments test/jdk/java/awt/Frame/FocusTest.java line 58: > 56: and then on the caption bar of the FocusTest Frame.) > 57: > 58: If the focus rectangle again appears, the test passes. Suggestion: If the focus rectangle appears again, the test passes. test/jdk/java/awt/Frame/InitialIconifiedTest.java line 71: > 69: } > 70: > 71: if (!FAILURES.toString().isBlank()) { Suggestion: if (!FAILURES.isEmpty()) { test/jdk/java/awt/Frame/InitialIconifiedTest.java line 85: > 83: // The following delay is commented out to capture this animation > 84: // robot.waitForIdle(); > 85: // robot.delay(500); Tested on macOS and windows. The test works on macOS with the work-around (extra delay) as described in the note. ------------- Marked as reviewed by honkar (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/21372#pullrequestreview-2353027700 PR Review Comment: https://git.openjdk.org/jdk/pull/21372#discussion_r1790943661 PR Review Comment: https://git.openjdk.org/jdk/pull/21372#discussion_r1790943372 PR Review Comment: https://git.openjdk.org/jdk/pull/21372#discussion_r1790942853
