On Wed, 9 Oct 2024 18:24:55 GMT, Harshitha Onkar <[email protected]> wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Test instruction update
>
> test/jdk/javax/swing/JFileChooser/bug4587721.java line 48:
>
>> 46: UIManager.setLookAndFeel(new MetalLookAndFeel());
>> 47: } catch (Exception e) {
>> 48: throw new RuntimeException(e);
>
> Shouldn't this be a SkippedException?
Metal is a standard cross-platform L&F. It absolutely should NOT be a
SkippedException.
So if this fails there's a problem.
The bit that I don't get is why bother to catch it only to throw again. Just
get rid of the try/catch.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21418#discussion_r1793975788
