On Mon, 14 Oct 2024 18:54:44 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:
>> Alexey Ivanov has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Rename instructions -> INSTRUCTIONS >> - Add @library and @build jtreg tags > > test/jdk/javax/swing/JButton/TimeChangeButtonClickTest.java line 87: > >> 85: .instructions(INSTRUCTIONS) >> 86: .rows(20) >> 87: .columns(40) > > Suggestion: > > .columns(40) > .testTimeOut(10) > > > We do have a pause timer option but I think a timeout of 8-10 mins is better > than the default of 5 mins since it allows more time for the user to change > the time settings. Actually, I think what is happening is that when the time is set forward an hour (+2 hours forward from 1 hour behind as in instructions) the test will automatically time out because it thinks an hour has passed. I thought initially it was me being slow on changing the time settings but even if you do everything quickly the test always fails exactly when you set the time forward. So I think with the way the timeout is implemented the test is broken with PassFailJFrame. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21476#discussion_r1802072122
