On Mon, 14 Oct 2024 16:40:35 GMT, Alexander Zvegintsev <[email protected]>
wrote:
>> Alisen Chung has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - fix small issues
>> - revert test to manual
>> - revert test to manual
>
> test/jdk/java/awt/Dialog/DialogDisposeLeak.java line 38:
>
>> 36: */
>> 37:
>> 38: public class DialogDisposeLeak {
>
> It looks like this test was oversimplified, as I no longer see steps to
> reproduce the original issue.
>
> https://bugs.openjdk.org/browse/JDK-4193022
>
>> Container.trackMouseEnterExit() calls startListeningForOtherDrags() when the
>> mouse pointer enters the container. It calls stopListeninForOtherDrags()
>> when the mouse exits the container.
>>
>> If the container is a window (in our case a JDialog), and the dispose()
>> method is called while the mouse pointer is within the window (user clicks
>> on the 'ok' button, for example), then the window is disposed, but no mouse
>> exit event occurs.
>>
>> This causes the window and everything it points to not to be collectable, as
>> there is still the Container drag listener pointing at the window.
i will revert this test to a manual test
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21488#discussion_r1805144921
