> After 8339120, gcc began catching many different instances of unused code in > the Windows specific codebase. Some of these seem to be bugs. I've taken the > effort to mark out all the relevant globals and locals that trigger the > unused warnings and addressed all of them by commenting out the code as > appropriate. I am confident that in many cases this simplistic approach of > commenting out code does not fix the underlying issue, and the warning > actually found a bug that should be fixed. In these instances, I will be > aiming to fix these bugs with help from reviewers, so I recommend anyone > reviewing who knows more about the code than I do to see whether there is > indeed a bug that needs fixing in a different way than what I did
Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Remove now unused result - Merge branch 'master' into accessibility - 8342870 ------------- Changes: - all: https://git.openjdk.org/jdk/pull/21656/files - new: https://git.openjdk.org/jdk/pull/21656/files/821307b5..de6afdb1 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=21656&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21656&range=00-01 Stats: 30420 lines in 378 files changed: 9472 ins; 19545 del; 1403 mod Patch: https://git.openjdk.org/jdk/pull/21656.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/21656/head:pull/21656 PR: https://git.openjdk.org/jdk/pull/21656
