On Wed, 30 Oct 2024 02:50:08 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org>
wrote:
> Couple of printing tests dont have "public" modifier so CI testing fails to
> run this test citing IllegalAccessException.
> Fix is made to made the test class public.
>
> Additionally, modified PrintDlgPageable.java to use PFJ and made
> StreamPrintingOrientation.java automated.
test/jdk/java/awt/print/Dialog/PrintDlgPageable.java line 54:
> 52: }
> 53: arg = Integer.parseInt(args[0]);
> 54: PrintDlgPageable pd = new PrintDlgPageable();
`pd` unused.
test/jdk/java/awt/print/Dialog/PrintDlgPageable.java line 97:
> 95:
> 96: //printable interface
> 97: public int print(Graphics g, PageFormat pf, int pi) throws
> PrinterException {
`throws PrinterException` not required.
test/jdk/javax/print/StreamPrintingOrientation.java line 52:
> 50:
> 51: public class StreamPrintingOrientation implements Printable {
> 52: public StreamPrintingOrientation() {
Can remove this constructor.
test/jdk/javax/print/StreamPrintingOrientation.java line 63:
> 61:
> 62: FileOutputStream fos = null;
> 63: File fl = null, fp = null;
`null` initialization is redundant here.
test/jdk/javax/print/StreamPrintingOrientation.java line 119:
> 117:
> 118: //printable interface
> 119: public int print(Graphics g, PageFormat pf, int pi) throws
> PrinterException {
`throws PrinterException` not required
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21780#discussion_r1822383533
PR Review Comment: https://git.openjdk.org/jdk/pull/21780#discussion_r1822384603
PR Review Comment: https://git.openjdk.org/jdk/pull/21780#discussion_r1822377674
PR Review Comment: https://git.openjdk.org/jdk/pull/21780#discussion_r1822379265
PR Review Comment: https://git.openjdk.org/jdk/pull/21780#discussion_r1822385021
