On Wed, 30 Oct 2024 12:51:13 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
> Test was pointing to missing html file, probably due to old Applet usage. > Test is updated to use PFJ.. test/jdk/java/awt/PrintJob/PrintCheckboxTest/PrintCheckboxManualTest.java line 52: > 50: 1. Click the 'Print' button on the frame > 51: 2. Select a printer in the print dialog and proceed > 52: 3. If the frame with checkbox and button on it is printed > successfully test PASSED else FAILED. The frame decorations look different between the printed and on-screen versions.  test/jdk/java/awt/PrintJob/PrintCheckboxTest/PrintCheckboxManualTest.java line 59: > 57: .title("Instructions") > 58: .instructions(INSTRUCTIONS) > 59: .rows((int) INSTRUCTIONS.lines().count() + 2) Suggestion: this is no longer needed, it is calculated automatically test/jdk/java/awt/PrintJob/PrintCheckboxTest/PrintCheckboxManualTest.java line 81: > 79: String[] instructions = > 80: { > 81: "Linux or Solaris with XToolkit ONLY!", > "Linux or Solaris with XToolkit ONLY!", Since this is removed in the updated test, I tried the test on macos, and it prints a blank page for me (to PDF, and to a paper) Have you verified the test on all platforms? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21786#discussion_r1823017222 PR Review Comment: https://git.openjdk.org/jdk/pull/21786#discussion_r1823014597 PR Review Comment: https://git.openjdk.org/jdk/pull/21786#discussion_r1823011788
