On Mon, 4 Nov 2024 21:29:51 GMT, Jiangli Zhou <jian...@openjdk.org> wrote:
>>> I notice incremental build with your current PR doesn't update >>> `static-jdk/bin/java` properly. This should be fixed as well. >> >> This I fully agree with; it cannot wait for a follow-up PR. I'll look into >> it as soon as I have gotten back to a working build. >> >> I can confirm that with your patch, and clang, and a complete wipe + >> rebuild, the .java file loading works. I'm currently testing with gcc as >> well. > >> I can confirm that with your patch, and clang, and a complete wipe + >> rebuild, the .java file loading works. I'm currently testing with gcc as >> well. > > Good. > > I tested using gcc. @jianglizhou Thank you for your assistance in figuring out the problem. I guess I throw out too much code from the hermetic-java-runtime branch when trying to minimize the changes to only build-related stuff. The jimage changes were so busy so I probably ignored them a bit too much. ------------- PR Comment: https://git.openjdk.org/jdk/pull/20837#issuecomment-2455741013
