On Thu, 7 Nov 2024 00:22:05 GMT, Daniel Gredler <d...@openjdk.org> wrote:
>> There are multiple issue with this test case
>> 1) Parser error due to yesno in @run main/manual=yesno
>> 2) User can only compare the UI rendering and compare with the print out.
>> User can't mark the test as pass or fail due to pass or fail buttons are
>> missing.
>> 3) When the test is executed using jtreg after user click on the print
>> button on the print dialog the whole test UIs ( frames) gets dispose and
>> user cannot compare the printout with the UI. But this works as expected in
>> test is running individually using java PrintTextTest
>
> Daniel Gredler has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Whitespace fixes
test/jdk/java/awt/print/PrinterJob/PrintTextTest.java line 219:
> 217: PassFailJFrame.builder()
> 218: .title("PrintTextTest")
> 219: .instructions(INSTRUCTIONS)
Suggestion:
.instructions(INSTRUCTIONS)
.testTimeOut(10)
I tried running the test and actually comparing the images… the timeout of 5
minutes is too short, we should increase the timeout to 10 or even 15 minutes.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21716#discussion_r1833090048
