On Thu, 14 Nov 2024 04:38:08 GMT, Phil Race <p...@openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comment
>
> src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/AnimationController.java
> line 28:
>
>> 26: package com.sun.java.swing.plaf.windows;
>> 27:
>> 28: import sun.security.action.GetBooleanAction;
>
> Still needed ?
removed
> src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/AnimationController.java
> line 71:
>
>> 69: @SuppressWarnings("removal")
>> 70: private static final boolean VISTA_ANIMATION_DISABLED =
>> 71:
>> Boolean.parseBoolean(System.getProperty("swing.disablevistaanimation"));
>
> remove @SuppressWarnings("removal") ?
> Boolean.getBoolean ?
ok
> src/java.desktop/windows/classes/sun/awt/windows/TranslucentWindowPainter.java
> line 69:
>
>> 67: // REMIND: we probably would want to remove this later
>> 68: private static final boolean forceOpt =
>> 69:
>> Boolean.parseBoolean(System.getProperty("sun.java2d.twp.forceopt", "false"));
>
> Boolean.getBoolean ?
ok
> src/java.desktop/windows/classes/sun/awt/windows/TranslucentWindowPainter.java
> line 71:
>
>> 69:
>> Boolean.parseBoolean(System.getProperty("sun.java2d.twp.forceopt", "false"));
>> 70: private static final boolean forceSW =
>> 71:
>> Boolean.parseBoolean(System.getProperty("sun.java2d.twp.forcesw", "false"));
>
> Boolean.getBoolean ?
ok
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22083#discussion_r1841724971
PR Review Comment: https://git.openjdk.org/jdk/pull/22083#discussion_r1841724842
PR Review Comment: https://git.openjdk.org/jdk/pull/22083#discussion_r1841725094
PR Review Comment: https://git.openjdk.org/jdk/pull/22083#discussion_r1841725192
