On Thu, 14 Nov 2024 18:22:25 GMT, altrisi <[email protected]> wrote: >> This is the first of a number of PRs to remove doPrivileged uses in client >> libraries. >> These calls are obsolete dead code after JEP 486. >> >> I have run all our automated tests, including JCK tests, and manually tested >> SwingSet. >> >> One thing I might have missed in a couple of cases is that it seems that >> javac doesn't seem to notice if you leave an un-needed >> SuppressWarnings("removal") annotation. >> >> As per the bug report I am limiting (as much as I can) what I touch here to >> be just the immediate consequences of removing doPrivileged calls. These >> changes are plenty enough as it is. > > src/java.desktop/share/classes/javax/swing/RepaintManager.java line 216: > >> 214: @SuppressWarnings("removal") >> 215: var t1 = "true".equals(AccessController. >> 216: doPrivileged(new GetPropertyAction( > > Missed the GetPropertyAction import for this file (can't annotate there)
This will need to be a follow-up at this point. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22090#discussion_r1842781314
