On Fri, 15 Nov 2024 22:32:54 GMT, Phil Race <[email protected]> wrote:
>> Skara hasn't removed the above "Terms of User" banner, but I'm pretty sure
>> that @msternermxy is right, and that this is not equivalent to the original.
>>
>> It should either be
>> `Boolean.parseBoolean(System.getProperty("sun.java2d.twp.forcesw",
>> "false"));` or else ~~`Boolean.parseBoolean("sun.java2d.twp.forcesw");`~~
>> -- the latter being OK because false is the default for a property that is
>> not set. Same for `forceOpt`.
>
> oops. he is right, Kevin you have a mistake
>
> "or else Boolean.parseBoolean("sun.java2d.twp.forcesw");" you mean
> Boolean.getBoolean(..) !
>
> I think the first change made was to
> Boolean.parseBoolean(System.getProperty("sun.java2d.twp.forceopt", "false"));
> and I suggested changing to the simpler Boolean.getBoolean() but I meant as a
> replacement for BOTH calls.
> ie to
> Boolean.getBoolean("sun.java2d.twp.forcesw")
> I didn't notice the mistake on re-review. I guess I too quickly assumed
> updates were likely to be corrections.
Yes, I realized that when I reread it.
`Boolean.getBoolean("sun.java2d.twp.forcesw")` is what I meant for my second
comment.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22083#discussion_r1844622832
