On Mon, 18 Nov 2024 05:59:59 GMT, Phil Race <[email protected]> wrote:
>> I will check windows build failure: >> https://github.com/bourgesl/jdk-official/actions/runs/11882209379/job/33107442693#step:10:1 > >> I will check windows build failure: >> https://github.com/bourgesl/jdk-official/actions/runs/11882209379/job/33107442693#step:10:1 > > D'oh. I missed that. this is C++. But you added the env arg. > Are you not building this locally ? Seems not. > If you have a windows-specific fix it is a good idea to have windows > available. @prrace build is ok. Approved ? ------------- PR Comment: https://git.openjdk.org/jdk/pull/21979#issuecomment-2482969927
