On Wed, 13 Nov 2024 15:57:13 GMT, Archie Cobbs <aco...@openjdk.org> wrote:
>> Please review this patch which removes unnecessary `@SuppressWarnings` >> annotations. > > Archie Cobbs has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains six additional > commits since the last revision: > > - Merge branch 'master' into SuppressWarningsCleanup-client > - Merge branch 'master' into SuppressWarningsCleanup-client > - Update copyright years. > - Merge branch 'master' into SuppressWarningsCleanup-client > - Merge branch 'master' into SuppressWarningsCleanup-client > - Remove unnecessary @SuppressWarnings annotations. Marked as reviewed by prr (Reviewer). OK .. looks like I didn't save my comments last time, trying again. I had missed this PR until recently. I think it will be good to have this sort of check. I've verified the specific changes here by building the PR on all platforms. I was a bit surprised how many serial annotations are present that are not needed There are in progress PRs that remove doPrivileged calls. They all involve removing lots of now redundant annotations and people don't always remember. There is good chance you will either want to do a follow-up of this PR, or re-run again against the latest master. ------------- PR Review: https://git.openjdk.org/jdk/pull/21850#pullrequestreview-2446598450 PR Comment: https://git.openjdk.org/jdk/pull/21850#issuecomment-2486694742
