On Wed, 23 Oct 2024 05:07:37 GMT, Julian Waters <jwat...@openjdk.org> wrote:
> After 8339120, gcc began catching many different instances of unused code in > the Windows specific codebase. Some of these seem to be bugs. I've taken the > effort to mark out all the relevant globals and locals that trigger the > unused warnings and addressed all of them by commenting out the code as > appropriate. I am confident that in many cases this simplistic approach of > commenting out code does not fix the underlying issue, and the warning > actually found a bug that should be fixed. In these instances, I will be > aiming to fix these bugs with help from reviewers, so I recommend anyone > reviewing who knows more about the code than I do to see whether there is > indeed a bug that needs fixing in a different way than what I did There's not much I like about this PR. I think it would be better to withdraw it and submit a bug against AWT for people to look at what should really be done about these cases. Which could include "do nothing". ------------- PR Comment: https://git.openjdk.org/jdk/pull/21655#issuecomment-2486391417
