On Wed, 18 Sep 2024 13:23:32 GMT, Sharath TN <[email protected]> wrote:
> Fixed test and fix is working fine. > > Fix > testUI(DefaultCloseOperation::createUI) will create PassfailJFrame test > windows when test starts. > > PassFailJFrame.addTestWindow(testFrame); > PassFailJFrame.addTestWindow(testDialog); > > Above code exists in the Test. So TestFrame and TestDailog windows will be > created when testUI(DefaultCloseOperation::createUI) invoked. > > Need to remove above code as this code is not required. Looks good. > ```java > PassFailJFrame.addTestWindow(testFrame); > PassFailJFrame.addTestWindow(testDialog); > ``` > > Above code exists in the Test. So `TestFrame` and `TestDailog` windows will > be created when `testUI(DefaultCloseOperation::createUI)` invoked. The issue is not that they're created but that they're *shown*… now… before the tester clicks any buttons. It confused me somewhat. Removing these is fine and it returns the test to its previous state… nearly. `TestFrame` and `TestDailog` aren't disposed of when the test shuts down. It's not a big issue. ------------- Marked as reviewed by aivanov (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/21061#pullrequestreview-2449400902 PR Comment: https://git.openjdk.org/jdk/pull/21061#issuecomment-2489277582
