On Wed, 20 Nov 2024 19:28:50 GMT, Phil Race <[email protected]> wrote:
>> @prrace Can you please advice on this particular code changes - Is it okay >> to catch IOException here or propagate it ? > > The existing code caught it and did not propagate it. > So it should be caught and not propagated - and do not add the > printStackTrace. > remove it. Thank you for clarifying. Updated. I didn't notice it earlier but the original exception `PrivilegedExceptionAction` was being caught but not re-thrown which now can be replace with IOException in similar way. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22218#discussion_r1850896038
