On Wed, 20 Nov 2024 22:21:57 GMT, Phil Race <[email protected]> wrote:
> Deprecate AudioPermission for removal. > > I found a test that uses it and updated it. > > The CSR needs to be reviewed too : https://bugs.openjdk.org/browse/JDK-8344658 Changes LGTM except for the SecurityException catch block removal in the test. test/jdk/javax/sound/sampled/Lines/GetLine.java line 49: > 47: } > 48: } > 49: Minor: These are on unchanged lines. Since AudioSystem.getLine(infos[0]) no longer throws security exception, the SecurityException catch block can be removed. try { l = AudioSystem.getLine(infos[0]); } catch(SecurityException lue) { log.println("SecurityException"); return STATUS_PASSED; } ------------- PR Review: https://git.openjdk.org/jdk/pull/22284#pullrequestreview-2449855057 PR Review Comment: https://git.openjdk.org/jdk/pull/22284#discussion_r1851084514
