On Thu, 21 Nov 2024 11:39:27 GMT, Prasanta Sadhukhan <[email protected]> wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> isPressed check and set > > test/jdk/javax/swing/JComboBox/JComboBoxScrollFocusTest.java line 44: > >> 42: should be scrolling down. Press ALT + TAB while holding >> down the >> 43: left click to switch focus to a different window. Focus the >> test >> 44: frame again and click the dropdown button for the JComboBox >> again. > > focus to a different window => and release the left click mouse button > Release of leftclick button was not mentioned anywhere above, guess you need > to add this. > > Also, since it is reproducible only via "down arrowbutton" and osx does not > have that, I guess we need to limit mac testing by adding "requires > (os.family != mac) " Added the point to the test instructions. Also added the exclusion of MacOS to the test. Thanks! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20845#discussion_r1852504471
