On Fri, 22 Nov 2024 19:35:49 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:

>> sun.awt.SunToolkit and sun.awt.image.URLImageSource are calling 
>> sun.net.util.URLUtil.getConnectPermission(URL)
>> With the SecurityManager gone there's no need to call this method anymore. 
>> 
>> There are other checkPermissions in these 2 files - SunToolkit, 
>> URLImageSource but I have removed only those that are related to 
>> URLUtil.getConnectPermission(URL). Other checkPermission removal will be 
>> handled in a separate issue.
>> 
>> Integrating this PR will allow to proceed with a dependent JBS issue - 
>> [JDK-8344180](https://bugs.openjdk.org/browse/JDK-8344180)
>
> Harshitha Onkar has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   removed java.desktop

src/java.desktop/share/classes/sun/awt/image/URLImageSource.java line 48:

> 46:             try {
> 47:                 java.security.Permission perm =
> 48:                       URLUtil.getConnectPermission(u);

`URLUtil.getConnectPermission(u);` is no longer used anywhere and can be removed


https://github.com/openjdk/jdk/commit/8c644ca310c44995a1fc899eabb5611b79873c68#diff-50e0953b57d7ba2dbb8faa9b1766b99234d5ae4cb271c48ece13b9e3d0c9ca89

so the jdk/src/java.base/share/classes/sun/net/util/URLUtil.java part can be 
reverted

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22330#discussion_r1854551012

Reply via email to