On Tue, 19 Nov 2024 21:35:25 GMT, Alisen Chung <[email protected]> wrote:
>> Cleaning up tests building ExtendedRobot that shouldn't be.
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fix imports
Looks good to me except for adding `robot.delay(500)`.
test/jdk/javax/swing/JInternalFrame/6725409/bug6725409.java line 142:
> 140: private static void sync() {
> 141: robot.waitForIdle();
> 142: robot.delay(500);
I still think `robot.delay(500);` is unnecessary in this test because the test
never accesses UI.
By adding `delay(500)` to the `sync` method you make the test run longer…
without a reason.
-------------
Marked as reviewed by aivanov (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20846#pullrequestreview-2455519770
PR Review Comment: https://git.openjdk.org/jdk/pull/20846#discussion_r1854575649
