On Tue, 26 Nov 2024 09:32:50 GMT, Alexander Zuev <[email protected]> wrote:
>> The fix for [JDK-8226990](https://bugs.openjdk.org/browse/JDK-8226990) >> causes regression in dark theme for GTK L&F on Ubuntu system and that >> results in manual test failures identified recently. >> >> Few of the changes made in >> [JDK-8226990](https://bugs.openjdk.org/browse/JDK-8226990) is further >> modified in [JDK-8335130](https://bugs.openjdk.org/browse/JDK-8335130). >> >> Backing out the overall fix to prevent any regression. >> >> CI testing after revert is fine. > > There was a test in the original PR. > test/jdk/javax/swing/JTabbedPane/TestJTabbedPaneOpaqueColor.java - should it > be corrected or problem-listed if you back out all the changes in the fix? Or > it will remain valid even without the original fix? > I guess @azuev-java is right...TestJTabbedPaneOpaqueColor.java was formed > from an existing test which was problemlisted and I removed it later on > [JDK-8339577](https://bugs.openjdk.org/browse/JDK-8339577) so you can > problemlist this test now under "# Client manual tests" section so that you > dont forget and tag it to that "Redo" JBS issue.. Test you have removed was problem-listed for `macOS` and as per [JDK-8331619](https://bugs.openjdk.org/browse/JDK-8331619) test is no longer valid for `Aqua L&F`. `TestJTabbedPaneOpaqueColor.java` is restricted to run only on **Linux and Windows** platform. Do we still need to problemlist it? ------------- PR Comment: https://git.openjdk.org/jdk/pull/22379#issuecomment-2502684483
