On Wed, 27 Nov 2024 18:46:47 GMT, Harshitha Onkar <[email protected]> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Test fix
>
> src/java.desktop/macosx/classes/com/apple/laf/AquaCaret.java line 209:
>
>> 207: y = alloc.y;
>> 208: width = alloc.width;
>> 209: height = alloc.height;
>
> Currently the test case tests the else branch (no border case), since the if
> branch is also modified, would it be better to test both cases - with and
> without border?
That is already being tested by existing testcases in CI and if I am not wrong
by SwingSet2 too..
> test/jdk/javax/swing/JTable/TestCaretArtifact.java line 68:
>
>> 66: new Object[] {"1", "2"});
>> 67:
>> 68: JFrame frame = new JFrame();
>
> JFrame title is missing
ok
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22416#discussion_r1861449729
PR Review Comment: https://git.openjdk.org/jdk/pull/22416#discussion_r1861449176
