On Wed, 4 Dec 2024 07:04:58 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
> test/jdk/javax/swing/JToolBar/4529206/bug4529206.java fails in OCI system
> citing
>
> Caused by: java.lang.RuntimeException: setFloating does not work correctly
> at bug4529206.lambda$main$3(bug4529206.java:90)
> at
> java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:308)
>
>
> which suggests that the focus is not shifted from main frame to toolbar..
> Added a stability waitForIdle and test passed in several OCI systems
test/jdk/javax/swing/JToolBar/4529206/bug4529206.java line 1:
> 1: /*
Since you are modifying this test, couple of suggestions:
1. Please limit L67 to 80 cols.
2. I guess L91 and L92 can be merged, it's slightly over 80 cols but should be
ok. If not then may be split like
throw new RuntimeException("setFloating" +
"does not work correctly");
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22536#discussion_r1869508259
