On Wed, 11 Dec 2024 09:13:48 GMT, Saagar Jha <d...@openjdk.org> wrote:
> Oops I guess I wasn't supposed to rebase on top of master. Sorry :( You must never use `git rebase` for a branch being reviewed. All your commits get new hashes as the result of the rebase operation, therefore all the comments become orphaned. The correct way is to use `git merge master -m 'Merge master'` after you pulled all the latest changes for master. --- However, as the bot has warned you https://github.com/openjdk/jdk/pull/22627#issuecomment-2524872307, you're using the `master` branch as the base branch for your contribution. *After this PR is integrated*, you'll have to handle diverged branches between the `master` branch in `openjdk/jdk` and your fork if you're going to contribute any other changes. To avoid this problem, you would create *a new branch* off the master branch for each bug / contribution. ------------- PR Comment: https://git.openjdk.org/jdk/pull/22627#issuecomment-2536186861
