On Wed, 18 Dec 2024 12:45:45 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   import
>
> test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java line 59:
> 
>> 57: 
>> 58:             SwingUtilities.invokeAndWait(() -> sbar.pressMouse());
>> 59:             mousePressLatch.await(2, TimeUnit.SECONDS);
> 
> Suggestion:
> 
>             if (!mousePressLatch.await(2, TimeUnit.SECONDS)) {
>                 throw new RuntimeException("Timed out waiting for mouse 
> press");
>             }
> 
> 
> If you don't throw the exception, the test will continue to run… Yet we're 
> sure it is likely to fail.

ok..modified..

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22783#discussion_r1890189015

Reply via email to