On Tue, 17 Dec 2024 20:46:54 GMT, Alisen Chung <[email protected]> wrote:
>> Currently on macOS when mouseMove is given an offscreen coordinate to move
>> the mouse to, mouseMove will physically clamp to the edge of the screen, but
>> if you try to grab the mouse location immediately after by using
>> MouseInfo.getPointerInfo().getLocation() you will get the value of the
>> offscreen point.
>>
>> Windows and linux do this clamping and coordinate handling for us, but new
>> distributions may not necessarily handle clamping the same way, so Robot
>> should be checking for clamping rather than delegating it to native.
>>
>> This fix updates shared code to cache the screen bounds and adds a check to
>> not exceed the bounds in mouseMove. The caching is done in the Robot
>> constructor, so if the screen bounds changes the constructor must be called
>> again to update to the new bounds.
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> fixed test to fail before fix and pass after fix
test/jdk/java/awt/Robot/MouseMoveOffScreen.java line 46:
> 44: Point currLoc = MouseInfo.getPointerInfo().getLocation();
> 45: System.out.println("Current mouse location: " + currLoc);
> 46: if(currLoc.equals(new Point(20000,200))) {
Suggestion:
if (currLoc.equals(new Point(20000, 200))) {
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22781#discussion_r1891405333
