On Thu, 21 Nov 2024 06:38:26 GMT, Andrey Turbanov <aturba...@openjdk.org> wrote:
> There is opportunity to remove redundant nested class `Metacity.ThemeGetter`. > It was introduced in the SecurityManager era to handle privileged call. Now > (after > https://github.com/openjdk/jdk/pull/22186/files#diff-5e3ecade1f409333dfba477b64039f86887d1febbff517407835fcac17a77b2a) > it's not the case and we can remove it. > It simplifies and streamlines logic. I don't know off the top of my head exactly what should be done here, but it seems odd to refactor obsolete code. A much more interesting task here would be to figure out if this code is even needed anymore. Metcity and gconf are SFAIK obsolete and probably this code should have been deleted when we removed gnome 2 support. You'll need to identify which Linux desktops versions still support this and how they interacts with GTK 3 .. if there's no overlap, then probably this code is never called. In which case it can be removed. ------------- PR Comment: https://git.openjdk.org/jdk/pull/22292#issuecomment-2555705187
