On Tue, 17 Dec 2024 17:11:05 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Then i would suggest doing both checks in both places. No need to even try >> to extract icon bits for hIcon == 0 but if we failed to extract icon for the >> correct handle we should handle it too. > > Yes, I did [suggest > it](https://github.com/openjdk/jdk/pull/22776#discussion_r1888597821) too. > > On the other hand, `makeIcon` starts with this condition > > https://github.com/openjdk/jdk/blob/4f44cf6bf2423a57a841be817f348e3b1e88f0eb/src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolder2.java#L1030-L1031 > > Anyway, not calling `makeIcon` when `hIcon == 0` is clearer. Do I retain or remove ` hIcon != 0L` check here ? Since now `hIcon != 0` is being checked before calling `mmakeIcon()`. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22776#discussion_r1896101949
