On Wed, 8 Jan 2025 05:51:22 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> Test seems to still fail in CI in ubuntu22.04 intermittently even after >> [JDK-8346324](https://bugs.openjdk.org/browse/JDK-8346324). Made the test >> headless similar to javax/swing/JScrollBar/bug4842792.java. > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > mac limitation Ran this myself locally and on CI with repeats. Making this headless is much nicer for testing. Results are passing and the changes LGTM. Minor phrasing suggestion, but OK overall. test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java line 50: > 48: String osName = System.getProperty("os.name"); > 49: if (osName.toLowerCase().contains("os x")) { > 50: System.out.println("This test is not for MacOS, considered > passed."); Suggestion: System.out.println("Ignoring this test for MacOS and passing instead."); Maybe something like this reads better. ------------- Marked as reviewed by dnguyen (Committer). PR Review: https://git.openjdk.org/jdk/pull/22937#pullrequestreview-2540526984 PR Review Comment: https://git.openjdk.org/jdk/pull/22937#discussion_r1909201804
