On Thu, 16 Jan 2025 22:28:08 GMT, David Holmes <dhol...@openjdk.org> wrote:
> @gerard-ziemski we should not have a bunch of Java files for this in the > hotspot source tree. Benchmarks should be in the test tree somewhere. Can > this not be integrated into existing benchmark frameworks i.e. JMH? The java related files are totally optional and are example of one way to analyze the results. They are NOT in `hotspot`, they are in `src/utils`: # ls -la src/utils total 0 drwxr-xr-x 7 gerard staff 224 Jan 14 13:09 . drwxr-xr-x 76 gerard staff 2432 Jan 14 13:09 .. drwxr-xr-x 24 gerard staff 768 Jan 13 15:46 IdealGraphVisualizer drwxr-xr-x 7 gerard staff 224 Jan 13 15:46 LogCompilation drwxr-xr-x 8 gerard staff 256 Jan 13 15:46 hsdis drwxr-xr-x 18 gerard staff 576 Jan 14 14:47 nmt drwxr-xr-x 3 gerard staff 96 Jan 13 15:46 src together with other weird tools. There are only 2 new files in `src/hotspot/share/nmt`: `memLogRecorder.cpp` and `memLogRecorder.hpp` ------------- PR Comment: https://git.openjdk.org/jdk/pull/23115#issuecomment-2598711069
