On Thu, 23 Jan 2025 11:47:08 GMT, Joachim Kern <jk...@openjdk.org> wrote:
> I reverted the changes in flags-cflags.m4 I still see them..? I think the changes you propose seem much better. Of course, in the end, the client team needs to agree to them to. The fp_pipewire.h looks trivially okay -- there seem to be no good reason to ever had that in a .h file that is just included in a .c file. The imageInitIDs.h changes looks good to me too. The solution previously employed was clever, but defies standard practice, and since it was only used there in the entire product, I think it is better to do as you propose. (Had we used that pattern everywhere, things would have been different.) ------------- PR Comment: https://git.openjdk.org/jdk/pull/23236#issuecomment-2609679299
