On Tue, 21 Jan 2025 19:48:52 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:

>> test/jdk/java/awt/color/ICC_Profile/ValidateICCHeaderData.java line 39:
>> 
>>> 37: 
>>> 38: public class ValidateICCHeaderData {
>>> 39:     private static ICC_Profile profile;
>> 
>> the change will also affect serialization, the test should check that code 
>> path.
>
> @mrserb @prrace 
> Added deserialization test case (as TestCase#15). 
> invalidSRGB.icc was serialized on JDK 21 and the same .icc profile was 
> deserialized here.
> As expected IAE is thrown in this case.
> 
> @mrserb All the previous comments have been addressed. Can you please 
> re-review the latest src code and test changes?

The new test is fine.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23044#discussion_r1927951109

Reply via email to