On Tue, 21 Jan 2025 13:42:05 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Julian Waters has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains eight commits: >> >> - Merge branch 'openjdk:master' into accessibility >> - Cast to void in AccessBridgeCalls.c >> - static_cast to void in jaccessinspector.cpp >> - Formatting changes in AccessBridgeEventHandler.cpp >> - Merge branch 'master' into accessibility >> - Remove now unused result >> - Merge branch 'master' into accessibility >> - 8342870 > > src/jdk.accessibility/windows/native/jabswitch/jabswitch.cpp line 364: > >> 362: } >> 363: >> 364: int regDeleteValue(HKEY hFamilyKey, LPCWSTR lpSubKey) > > There's one more memory leak: > > https://github.com/openjdk/jdk/blob/4a9fba615da0dfa6646ecb9fd9d929f74fe6875e/src/jdk.accessibility/windows/native/jabswitch/jabswitch.cpp#L352 > > The `delete[]` operator must be called on `newStr`. > > It's present in both `regEnable` and `regDeleteValue`. I'll also submit a new bug against it. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21656#discussion_r1929203791
