On Mon, 27 Jan 2025 17:25:58 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:
>Is this question applicable only for Rendering Intent or other fields too? For other fields too. Note, before this fix the following method iccCStoJCS was used to convert icc constant to java constant and if it was not possible an exception was thrown. One of the reasons it was not possible is because we do not cover all variants as java constants so we cannot return anything useful from getPCSType/etc, but it was still possible to use such profiles for color conversion. This patch starts using iccCStoJCS as the source of truth. I'm not sure if this is correct or not. We can double-check that it covers all valid cases, so we can reject everything else. But the existing checks that are already in the constructor can be safely added. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23044#discussion_r1931379481
