On Fri, 31 Jan 2025 02:36:50 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:
> @anass-baya Fix looks good to me. > > Initially the test passed without the fix, I realized that I had the option > **"Show taskbar on all displays"** checked in Settings, after unchecking it > the test works as expected with the fix. I have the option **Show taskbar on all displays** selected, yet the test didn't work for me initially. It depends on whether the main monitor happens to be the first screen in graphics environment. If not, you get wrong results. I cannot reproduce the problem at this moment, my main monitor is the first one in the list. I [reproduced the problem](https://bugs.openjdk.org/browse/JDK-6899304?focusedId=14594269&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14594269) when three monitors were connected, I used a different laptop at that time. > Suggestion: Based on other reviewers opinion you can choose to combine > MultiScreenInsetsTest & ScreenInsetsTest. [#23183 > (comment)](https://github.com/openjdk/jdk/pull/23183#discussion_r1936568297) Yes, we should combine the two tests. However, I'd rather do it separately. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23183#issuecomment-2626920314
