On Mon, 3 Feb 2025 07:00:58 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> test/jdk/java/awt/PopupMenu/PopupMenuVisuals.java line 50:
>
>> 48: - Menu is disabled
>> 49: - Menu has caption 'Popup menu' (only applicable for linux)
>> 50: - Menu items don't show shortcuts (except on MacOS)
>
> Is it good to restrict the test for "Windows and Linux" only ?
It still tests for PopupMenu visuals on MacOS I suppose. We can still see if a
disabled PopupMenu appears correctly. It's also a manual test. Not sure if
restricting the test is actually required unless there's a bigger reason I'm
missing.
> test/jdk/java/awt/PopupMenu/PopupMenuVisuals.java line 84:
>
>> 82: //Get things going. Request focus, set size, et cetera
>> 83: frame = new Frame("PopupMenuVisuals");
>> 84: frame.setSize(200,200);
>
> Suggestion:
>
> frame.setSize(200, 200);
Fixed, thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23402#discussion_r1939788579
PR Review Comment: https://git.openjdk.org/jdk/pull/23402#discussion_r1939791371
