On Mon, 3 Feb 2025 17:49:15 GMT, Damon Nguyen <[email protected]> wrote:
>> The test instructions say that disabled PopupMenus should not have shortcuts
>> shown, but on MacOS, these shortcuts still appear. When checking native
>> MacOS15 behavior, disabled PopupMenus still have shortcuts shown. Since the
>> test doesn't modify the popup's shortcuts other than adding the shortcut for
>> `A`, it makes sense that the result matches native behavior. So, I modified
>> the test instructions instead to exclude MacOS from this step.
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review comments
Test changes looks good to me.
test/jdk/java/awt/PopupMenu/PopupMenuVisuals.java line 81:
> 79: Menu sm = new Menu("Submenu");
> 80:
> 81: //Get things going. Request focus, set size, et cetera
minor formatting change
Suggestion:
// Get things going. Request focus, set size, et cetera
-------------
Marked as reviewed by abhiscxk (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23402#pullrequestreview-2590664941
PR Review Comment: https://git.openjdk.org/jdk/pull/23402#discussion_r1939819092
