On Tue, 4 Feb 2025 00:07:48 GMT, anass baya <d...@openjdk.org> wrote:
> The PR includes two fix : > 1 - The first fix targets proper rendering of the transparent image. > 2 - The second fix ensures the image is painted at the correct resolution to > avoid pixelation. src/java.desktop/macosx/classes/sun/java2d/opengl/CGLGraphicsConfig.java line 279: > 277: } > 278: }; > 279: } Should this new `createAcceleratedImage(..)` logic be moved to `CGraphicsConfig`? This looks like copied and pasted code in two subclasses that could be abstracted into the parent class. (I could be wrong here; I just wanted to check opinions...?) It looks like these two classes (MTLGraphicsConfig and CGLGraphicsConfig) are the only subclasses for CGraphicsConfig. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23430#discussion_r1940699051
