On Fri, 31 Jan 2025 20:40:27 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:

>> The `javax/swing/JButton/4796987/bug4796987.java` test strictly verifies if 
>> it's run on Windows XP, for this reason it never runs on modern versions of 
>> Windows.
>> 
>> Since Windows XP is obsolete and visual styles cannot be disabled since 
>> Windows 8, I removed the OS version check completely.
>> 
>> I captured an image of the panel and analyse colors in the image instead of 
>> using `Robot.getPixelColor`; I save the image for reference if the test 
>> fails.
>> 
>> The updated test passes in the CI.
>
> Alexey Ivanov has updated the pull request incrementally with two additional 
> commits since the last revision:
> 
>  - Update the test summary
>  - Remove the redundant button

Marked as reviewed by tr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/23336#pullrequestreview-2595331966

Reply via email to