On Sun, 9 Feb 2025 14:39:13 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> I note that AIX seems to be the biggest beneficiary here. It doesn't seem to >> be a big deal for anything else. >> >> I think what we are looking for in testing is no functional regression plus >> minimal perf impact on startup. >> But I don't think any of our jtreg tests are set up to measure the perf so >> can only ensure the functional. >> It would be good to check that as mentioned. >> And I don't remember anyone ever testing perf of splash since the point of >> splash is to mask the much bigger hit of booting up the JVM .. so I doubt >> we'll be able to test it today. >> But I'll make a note to self to ask the people who do perf testing to think >> about this, or perhaps tell me "gosh Phil, we've been testing that forever, >> didn't you know" ? > >> I note that AIX seems to be the biggest beneficiary here. It doesn't seem to >> be a big deal for anything else. > > Please note that AIX has the debuginfo in the same binary (.so file), unlike > e.g. Linux. > If you look at the size reduction of the debuginfo files on Linux, this goes > down from 1.7M -> 1.4M on Linux x86_64 so it is also quite a good reduction. > @MBaesken > > > However I think I have to run some more manual tests on client like setups. > > SplashScreen clientlib tests are located - test/jdk/java/awt/SplashScreen. > Most of them are manual tests invoked by shell script and it is easier to run > the whole test folder. I can run the tests on your behalf to check if the > tests work fine with the fix. > > What are we specifically looking for in the tests with this fix? No > degradation in test startup and execution time? If you find the time to run those, would be great. And yes a noticeable degradation would be important to know. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23493#issuecomment-2646333958
