On Mon, 3 Feb 2025 18:50:41 GMT, Alexander Zvegintsev <azveg...@openjdk.org> 
wrote:

> This changeset updates the pipewire headers to the latest available version.
> It contains the minimum set of required header files needed to build the JDK.
> 
> The updated headers are a direct copy from the 
> https://gitlab.freedesktop.org/pipewire/pipewire/-/releases/1.3.81 (except 
> for the `\t` -> `    ` replacement)
>  
> Testing looks good.

@azvegint 
Update looks good. Local build looks good. 
Tests work the same without and with the upgrade. No regression observed.

One thing that I noticed and wanted discuss further: when I delete the 
screencast-tokens.properties file and the permission is granted for the first 
screen share (new token generated), it asks for permission every time for 
subsequent screen share and I see multiple screencast tokens in the .properties 
file instead of one. IIRC the token setup is one time and the subsequent 
requests are there after allowed or am I missing some setup step ?

Note: This is not related to the upgrade (happens even without the fix)

-------------

PR Review: https://git.openjdk.org/jdk/pull/23426#pullrequestreview-2607484981

Reply via email to