On Tue, 18 Feb 2025 07:45:06 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> 
wrote:

> Test is failing in ubuntu 23.x and beyond with expected red pixel not being 
> picked up
> Increase in fontsize increase the possibility of font red pixel being picked 
> up. 
> Test is now passing in ubuntu 24.04 and in CI..

The fix looks good to me.

However, the JBS bug should be more specific: the PR doesn't only remove the 
`javax/swing/JComboBox/TestComboBoxComponentRendering.java` test from the 
problem list, it modifies the test so that it can be removed from the 
problem-list.

Therefore, the subject of the bug has to reflect this additional change. 
(*“Increase font size in 
javax/swing/JComboBox/TestComboBoxComponentRendering.java”* isn't a bad 
candidate in my opinion.)

The current subject would be fine if you only removed the test from PL without 
modifying it.

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23670#pullrequestreview-2623177171

Reply via email to