On Mon, 17 Feb 2025 05:51:36 GMT, Jayathirth D V <j...@openjdk.org> wrote:
>> src/java.desktop/share/classes/java/awt/color/ICC_Profile.java line 1154: >> >>> 1152: * This method is useful for advanced applications which need to >>> access >>> 1153: * profile data directly. Only non-BuiltIn profiles can be >>> updated using >>> 1154: * this method. >> >> @prrace >> I added this additional line here mentioning that only non-BuiltIn profiles >> can be updated. Does it look okay or do you recommend any changes ? > > I think here also language should be similar to what we use in `@throws > IllegalArgumentException`. Using just "non-BuiltIn profiles" doesn't give > full picture. @prrace @jayathirthrao Thanks! Updated both the PR as per CSR changes. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23606#discussion_r1962495024
