On Sat, 22 Feb 2025 02:10:46 GMT, Alexander Zvegintsev <azveg...@openjdk.org> wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add test helper > > test/jdk/javax/swing/JComboBox/JComboBoxScrollFocusTest.java line 43: > >> 41: * @key headful >> 42: * @bug 6672644 >> 43: * @requires os.family != "mac" > > Is there a reason to exclude it on mac? > > Based on my local testing, the issue doesn't affect mac (test passes before > and after the fix), but we can still run the test. I excluded mac because it didn't have an increase/decrease button for the scrollbar. However, I see with the automated test that this doesn't really matter because clicking above or below the slider still increments/decrements the value. Removed the mac exclusion. Thanks again! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23451#discussion_r1968455152
