On Thu, 27 Feb 2025 11:29:36 GMT, Roman Marchenko <[email protected]>
wrote:
>> Fixed `com.sun.beans.introspect.MethodInfo#MethodOrder` to make
>> `Introspector.addMethod()` working properly when filtering methods out.
>>
>> Also, after PR discussion, added the approptiate test cases with
>> corresponding fixes in MethodInfo.java and PropertyInfo.java.
>
> Roman Marchenko has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Symmetric fix
src/java.desktop/share/classes/com/sun/beans/introspect/PropertyInfo.java line
98:
> 96: writeType = info.type;
> 97: } else if (writeType.isAssignableFrom(info.type)) {
> 98: if ((this.write == null) || (!info.method.isDefault()
> && this.write.type.isAssignableFrom(info.type))) {
I cannot reproduce this because of the sorting, however it's reproduced without
sorting.
Added this to make the fix symmetric between read/write properties.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23443#discussion_r1973398822
