On Mon, 24 Feb 2025 19:17:10 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> There are other way to create a profile - directly loading it from a file >> (serialization) >> `ICC_Profile.getInstance(<path to sRGB.pf or any custom profiles>); `or >> using the byte array representation of the profile. So the main intention >> here was not to tie ProfileDeferralInfo with isBuiltIn. > >> There are other way to create a profile - directly loading it form a file >> (serialization) `ICC_Profile.getInstance(<path to sRGB.pf or any custom >> profiles>); `or using the byte array representation of the profile. So the >> main intention here was not to tie ProfileDeferralInfo with isBuiltIn. > > Yes, there are. Does any other way create a **built-in profile**? No, it > doesn't as far as I can see. > > Is this flexibility needed? I'd say, it's not needed… unless there's a very > high chance there'll soon be introduced a new build-in ICC profile which is > created in another way but `ICC_Profile(ProfileDeferralInfo)` constructor. @aivanov-jdk Updated the code and moved `builtIn` flag to be set in the constructor. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23606#discussion_r1976182029
