On Mon, 3 Mar 2025 17:46:36 GMT, Sergey Bylokhov <[email protected]> wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> doc update
>
> src/java.desktop/share/classes/java/awt/color/ICC_Profile.java line 1156:
>
>> 1154: * {@link ColorSpace#CS_sRGB}, {@link ColorSpace#CS_LINEAR_RGB},
>> 1155: * {@link ColorSpace#CS_PYCC}, {@link ColorSpace#CS_GRAY} or
>> 1156: * {@link ColorSpace#CS_CIEXYZ}.
>
> The standard profile could be acquired by the application via serialization
> as well, but I'm not sure if we should mention it.
This builtin flag check is exclusively for JDK built-in profiles created within
the private interface `BuiltInProfile` and not applicable if an application
loads the profile by serialization.
Since `BuiltInProfile` interface and `builtin` flag are private we could not
include it in javadoc hence used ICC_Profile.getInstance(int colorspaceID) to
specify built-in profile. Please let us know if the javadoc sound okay or
requires any changes?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23606#discussion_r1977966082
