On Tue, 4 Mar 2025 14:11:27 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:

>> test/jdk/javax/swing/JMenu/4213634/bug4213634.java line 42:
>> 
>>> 40:  * @key headful
>>> 41:  * @bug 4213634 8017187
>>> 42:  * @library ../../regtesthelpers
>> 
>> Suggestion:
>> 
>>  * @library /java/awt/regtesthelpers
>
> It must be `/javax/swing/regtesthelpers`.
> 
> There's also a `Util` class in `/java/awt/regtesthelpers` but it doesn't have 
> the `hitMnemonics` method.
> 
> (It's somewhat confusing.)

To be clear, leaving `@library ../../regtesthelpers` is fine with me, I was 
objecting to Harshitha's suggestion. If an absolute path is used, it must refer 
to the Swing version of the `Util` class.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23837#discussion_r1979566870

Reply via email to